Skip to content

Conversation

@ldufr
Copy link
Contributor

@ldufr ldufr commented Nov 27, 2025

What this PR does

This add a benchmark that tests the processing of a large OTLP message marshaled to protobuf.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

Note

Adds a benchmark that measures OTLP handler performance with a large protobuf metrics payload.

  • Benchmarks:
    • Add BenchmarkOTLPHandlerWithLargeMessage in pkg/distributor/otel_test.go to measure processing of a large OTLP protobuf metrics request (many ResourceMetrics/Metrics/datapoints), using OTLPHandler with increased maxMsgSize.

Written by Cursor Bugbot for commit 0943231. This will update automatically on new commits. Configure here.

@ldufr ldufr requested a review from a team as a code owner November 27, 2025 14:50
@ldufr ldufr added the changelog-not-needed PRs that don't need a CHANGELOG.md entry label Nov 27, 2025
@ldufr ldufr force-pushed the ldufresne/add-benchmark-large-otlp-message branch 2 times, most recently from b748748 to b1d27a6 Compare November 27, 2025 15:16
@ldufr ldufr changed the title benchmark: add benchmark processing large OTLP messages :dev: benchmark: add benchmark processing large OTLP messages Nov 27, 2025
@ldufr ldufr force-pushed the ldufresne/add-benchmark-large-otlp-message branch from b1d27a6 to 405ed22 Compare November 27, 2025 15:23
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, but please see comments.

@ldufr ldufr force-pushed the ldufresne/add-benchmark-large-otlp-message branch 2 times, most recently from e40c7b8 to cf6ebf8 Compare December 3, 2025 09:13
Signed-off-by: Laurent Dufresne <laurent.dufresne@grafana.com>
@ldufr ldufr force-pushed the ldufresne/add-benchmark-large-otlp-message branch from cf6ebf8 to 0943231 Compare December 3, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-not-needed PRs that don't need a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants