[r369] usage-tracker: check partition handler service state before serving tracking requests #13547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racking requests (#13532) #### What this PR does When new partition handler is created, it's immediately assigned to the partitions map, but it's not ready to serve requests until it's Running. In case some replica tries to send us a request, we should check that. #### Which issue(s) this PR fixes or relates to None #### Checklist - [x] Tests updated. - [ ] Documentation added. - [x] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Usage-tracker now rejects requests to partitions whose handlers aren’t in Running state, with tests added/updated and changelog entry included. > > - **Usage-tracker**: > - Add `runningPartition()` and use it in `TrackSeries()` and `GetUsersCloseToLimit()` to require a `services.Running` partition; return an error otherwise. > - Refactor and extend tests: > - New cases ensuring errors when a partition handler is terminated. > - Restructure `GetUsersCloseToLimit` tests and add non-running partition case. > - **Docs/Meta**: > - Update `CHANGELOG.md` with a `[BUGFIX]` entry for guarding against non-running partition handlers. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 42405da. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> (cherry picked from commit 282e14c)
mimir-github-bot
bot
requested review from
colega
and removed request for
a team
colega
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 282e14c from #13532
Note
Usage-tracker now rejects requests to partitions that aren’t in Running state, adding a common check used by
TrackSeriesandGetUsersCloseToLimit, with tests and changelog updated.runningPartition().TrackSeriesandGetUsersCloseToLimitto return errors if handler is missing or notservices.Running.GetUsersCloseToLimittests.Written by Cursor Bugbot for commit 6b8e627. This will update automatically on new commits. Configure here.