-
Notifications
You must be signed in to change notification settings - Fork 679
Redpanda also works with Mimir #13502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
i love grafana, excited to add to the ecosystem |
dimitarvdimitrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing!! Thanks for contributing that!
I'm not sure if the section on redpanda isn't too marketing-inclined, but I'll leave @tacole02 weigh in on that one
tacole02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this! Overall this looks good. I left a few comments and suggestions.
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: YAML frontmatter accidentally removed from documentation
The YAML frontmatter containing aliases, description, menuTitle, title, and weight fields was removed from the documentation file. This metadata is essential for the documentation system to generate proper navigation, SEO metadata, and URL aliases. Other files in docs/sources/mimir/configure/ retain this frontmatter, and a reviewer has requested its restoration.
docs/sources/mimir/configure/configure-kafka-backend.md#L1-L8
mimir/docs/sources/mimir/configure/configure-kafka-backend.md
Lines 1 to 8 in 7b9e098
| # Configure the Grafana Mimir Kafka backend | |
| Grafana Mimir supports using Kafka as the first layer of ingestion in the ingest storage architecture. This configuration allows for scalable, decoupled ingestion that separates write and read paths to improve performance and resilience. | |
| Starting with Grafana Mimir 3.0, ingest storage is the preferred and stable architecture for running Grafana Mimir. | |
| ## Configure ingest storage | |
56quarters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This copy feels a little too much like marketing. Could you please limit the section for Red Panda to the same information as other Kafka implementations?
|
@tacole02 I just incorporated all of your feedback, can you merge in please 🙏 ? |
merged main into my branch
|
I incorpoarted all the changes and simplified the document, please merge in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Could you please move the Warpstream and Redpanda blocks to keep them in alphabetical order? Otherwise LGTM
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Updates Kafka backend docs to add Redpanda (uses defaults with example link) and clarify Warpstream flag, keeping Apache/Confluent as default setups.
Redpanda(uses default options) with a working example link.Warpstreamsetup by specifying-ingest-storage.kafka.use-compressed-bytes-as-fetch-max-bytes=false.Apache KafkaandConfluent Kafkanoted as requiring no additional config.Written by Cursor Bugbot for commit 2882b41. This will update automatically on new commits. Configure here.