Skip to content

Conversation

@meticulo3366
Copy link

@meticulo3366 meticulo3366 commented Nov 14, 2025

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

Note

Updates Kafka backend docs to add Redpanda (uses defaults with example link) and clarify Warpstream flag, keeping Apache/Confluent as default setups.

  • Docs (Kafka backend configuration):
    • Add guidance for Redpanda (uses default options) with a working example link.
    • Clarify Warpstream setup by specifying -ingest-storage.kafka.use-compressed-bytes-as-fetch-max-bytes=false.
    • Keep Apache Kafka and Confluent Kafka noted as requiring no additional config.
    • Remove duplicate Warpstream section and organize backend variants.

Written by Cursor Bugbot for commit 2882b41. This will update automatically on new commits. Configure here.

@meticulo3366 meticulo3366 requested review from a team and tacole02 as code owners November 14, 2025 19:58
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2025

CLA assistant check
All committers have signed the CLA.

@meticulo3366
Copy link
Author

i love grafana, excited to add to the ecosystem

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!! Thanks for contributing that!

I'm not sure if the section on redpanda isn't too marketing-inclined, but I'll leave @tacole02 weigh in on that one

Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this! Overall this looks good. I left a few comments and suggestions.

meticulo3366 and others added 4 commits November 19, 2025 12:45
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: YAML frontmatter accidentally removed from documentation

The YAML frontmatter containing aliases, description, menuTitle, title, and weight fields was removed from the documentation file. This metadata is essential for the documentation system to generate proper navigation, SEO metadata, and URL aliases. Other files in docs/sources/mimir/configure/ retain this frontmatter, and a reviewer has requested its restoration.

docs/sources/mimir/configure/configure-kafka-backend.md#L1-L8

# Configure the Grafana Mimir Kafka backend
Grafana Mimir supports using Kafka as the first layer of ingestion in the ingest storage architecture. This configuration allows for scalable, decoupled ingestion that separates write and read paths to improve performance and resilience.
Starting with Grafana Mimir 3.0, ingest storage is the preferred and stable architecture for running Grafana Mimir.
## Configure ingest storage

Fix in Cursor Fix in Web


Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copy feels a little too much like marketing. Could you please limit the section for Red Panda to the same information as other Kafka implementations?

@meticulo3366
Copy link
Author

@tacole02 I just incorporated all of your feedback, can you merge in please 🙏 ?

@meticulo3366
Copy link
Author

I incorpoarted all the changes and simplified the document, please merge in

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you please move the Warpstream and Redpanda blocks to keep them in alphabetical order? Otherwise LGTM

@56quarters 56quarters added the changelog-not-needed PRs that don't need a CHANGELOG.md entry label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-not-needed PRs that don't need a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants