Alertmanager to store fingerprint of configuration instead of structure #12087
+286
−277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
added
component/alertmanager
changelog-not-needed
yuri-tceretian
force-pushed
the
yuri-tceretian/config-hash
branch
from
04f2a4a to
09ae47d
Compare
^ Conflicts: ^ pkg/alertmanager/multitenant.go
yuri-tceretian
force-pushed
the
yuri-tceretian/config-hash
branch
from
09ae47d to
67a7899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR improves multitenant Alertmanager to store a fingerprint of user configuration instead of a full structure. The structure uses this field to compare current configuration with one loaded from the storage and skip applying the configuration if it's not changed.
I decided to implement this function on my own and add necessary tests to assert the correctness of the fingerprint and protect for unintended modifications in future. The method uses approach that has been well tested in Grafana .
This PR is built on top of the refactoring #12052