-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixin: add GEM-flavoured compiled mixin #10690
mixin: add GEM-flavoured compiled mixin #10690
Conversation
This is intended to be used by GEM installations. Soon it will include GEM-specific dashboards and alerts. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
_config+:: { | ||
gem_enabled: true, | ||
|
||
gateway_enabled: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make gateway_enabled
default to true
if gem_enabled
is true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep; will do in the next PR because gem_enabled isn't actually defined
* mixin: add GEM-flavoured compiled mixin This is intended to be used by GEM installations. Soon it will include GEM-specific dashboards and alerts. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Remove zip file --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
* mixin: add GEM-flavoured compiled mixin This is intended to be used by GEM installations. Soon it will include GEM-specific dashboards and alerts. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Remove zip file --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
What this PR does
This is intended to be used by GEM installations. Soon it will include GEM-specific dashboards and alerts.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.