Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: add GEM-flavoured compiled mixin #10690

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

dimitarvdimitrov
Copy link
Contributor

What this PR does

This is intended to be used by GEM installations. Soon it will include GEM-specific dashboards and alerts.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

This is intended to be used by GEM installations. Soon it will include GEM-specific dashboards and alerts.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

_config+:: {
gem_enabled: true,

gateway_enabled: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make gateway_enabled default to true if gem_enabled is true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep; will do in the next PR because gem_enabled isn't actually defined

@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) February 20, 2025 07:51
@dimitarvdimitrov dimitarvdimitrov merged commit e17e336 into main Feb 20, 2025
28 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/mixin/add-gem-flavoured-compiled-mixin branch February 20, 2025 08:16
ying-jeanne pushed a commit that referenced this pull request Feb 20, 2025
* mixin: add GEM-flavoured compiled mixin

This is intended to be used by GEM installations. Soon it will include GEM-specific dashboards and alerts.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Update CHANGELOG.md

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Remove zip file

---------

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
ying-jeanne pushed a commit that referenced this pull request Feb 20, 2025
* mixin: add GEM-flavoured compiled mixin

This is intended to be used by GEM installations. Soon it will include GEM-specific dashboards and alerts.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Update CHANGELOG.md

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Remove zip file

---------

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants