Skip to content

Conversation

codesome
Copy link
Contributor

What this PR does

This PR adds a flag for the feature that has been already merged.

Which issue(s) this PR fixes or relates to

Fixes #9911

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

codesome and others added 2 commits November 27, 2024 12:47
…ag (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
@codesome codesome requested review from tacole02 and a team as code owners November 27, 2024 17:53
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
@codesome codesome requested a review from chencs November 27, 2024 17:53
@codesome codesome merged commit 832d02b into main Nov 27, 2024
30 checks passed
@codesome codesome deleted the codesome/24hblockflag branch November 27, 2024 18:59
@grafanabot
Copy link
Contributor

The backport to r318 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-10035-to-r318 origin/r318
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 832d02b54e4e83c8da3ecc47586cf3a13e77dd94
# Push it to GitHub
git push --set-upstream origin backport-10035-to-r318
git switch main
# Remove the local backport branch
git branch -D backport-10035-to-r318

Then, create a pull request where the base branch is r318 and the compare/head branch is backport-10035-to-r318.

@grafanabot
Copy link
Contributor

The backport to r316 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-10035-to-r316 origin/r316
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 832d02b54e4e83c8da3ecc47586cf3a13e77dd94
# Push it to GitHub
git push --set-upstream origin backport-10035-to-r316
git switch main
# Remove the local backport branch
git branch -D backport-10035-to-r316

Then, create a pull request where the base branch is r316 and the compare/head branch is backport-10035-to-r316.

@grafanabot
Copy link
Contributor

The backport to r317 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-10035-to-r317 origin/r317
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 832d02b54e4e83c8da3ecc47586cf3a13e77dd94
# Push it to GitHub
git push --set-upstream origin backport-10035-to-r317
git switch main
# Remove the local backport branch
git branch -D backport-10035-to-r317

Then, create a pull request where the base branch is r317 and the compare/head branch is backport-10035-to-r317.

codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035) (#10091)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035) (#10092)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
codesome added a commit that referenced this pull request Dec 2, 2024
…flag (#10035) (#10090)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag  (#9981)

* Add blocks-storage.tsdb.bigger-out-of-order-blocks-for-old-samples flag

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Update pkg/storage/tsdb/config.go

Co-authored-by: chencs <casie.chen@grafana.com>

* Make flag experimental

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* CHANGELOG

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

---------

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: chencs <casie.chen@grafana.com>
(cherry picked from commit 832d02b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingester: Produce bigger out-of-order blocks for old data
3 participants