Skip to content

When using multi KV Store, runtime config changes are used only in ingester ring. #996

Closed

Description

Runtime config contains multi_kv_config field, which can set current store to use when ring is configured with multi KV store.

However runtime config changes are currently only reflected in ingester ring (in ingesters and distributor/querier/rulers). Reason is that only initIngesterService and initRing methods in modules.go initialize ConfigProvider in kv.MultiConfig struct.

t.Cfg.Ingester.LifecyclerConfig.RingConfig.KVStore.Multi.ConfigProvider = multiClientRuntimeConfigChannel(t.RuntimeConfig)

We need to do the same in all ring configs that can use multi KV. I think we should reuse the same multi_kv_config field in runtime config for ALL ring stores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions