Skip to content

Commit

Permalink
Ops: Also set server.grpc-max-send-msg-size-bytes on ruler-queriers (#…
Browse files Browse the repository at this point in the history
…10676)

This should match what the ruler-query-frontend is configured for.

Re-do of #10208 after rolling out progressively in Grafana cloud.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
  • Loading branch information
56quarters authored Feb 17, 2025
1 parent b7da5d9 commit b87c3e2
Show file tree
Hide file tree
Showing 23 changed files with 27 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-tests/test-autoscaling-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1509,6 +1509,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1509,6 +1509,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1509,6 +1509,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1409,6 +1409,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1482,6 +1482,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1486,6 +1486,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1486,6 +1486,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1495,6 +1495,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1515,6 +1515,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1515,6 +1515,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1515,6 +1515,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1450,6 +1450,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1450,6 +1450,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1427,6 +1427,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1509,6 +1509,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,7 @@ spec:
- -query-scheduler.ring.store=memberlist
- -query-scheduler.service-discovery-mode=ring
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1161,6 +1161,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,7 @@ spec:
- -query-frontend.results-cache.memcached.timeout=500ms
- -query-frontend.scheduler-address=ruler-query-scheduler-discovery.default.svc.cluster.local.:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc-max-recv-msg-size-bytes=104857600
- -server.grpc-max-send-msg-size-bytes=104857600
- -server.grpc.keepalive.max-connection-age=30s
- -server.grpc.keepalive.max-connection-age-grace=5m
Expand Down
5 changes: 5 additions & 0 deletions operations/mimir/ruler-remote-evaluation.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
$.querier_args +
$.querierUseQuerySchedulerArgs(rulerQuerySchedulerName) + {
'querier.max-concurrent': $._config.ruler_querier_max_concurrency,
} + if !useRulerQueryFrontend then {} else {
// The ruler-querier sends a query response back to the ruler-query-frontend
'querier.frontend-client.grpc-max-send-msg-size': $._config.ruler_remote_evaluation_max_query_response_size_bytes,
},

ruler_querier_env_map:: $.querier_env_map {
Expand Down Expand Up @@ -68,6 +71,8 @@
// Result caching is of no benefit to rule evaluation, but the cache can be used for storing cardinality estimates.
'query-frontend.cache-results': false,

// The ruler-query-frontend receives the query response back from the ruler-querier.
'server.grpc-max-recv-msg-size-bytes': $._config.ruler_remote_evaluation_max_query_response_size_bytes,
// The ruler-query-frontend sends the query response back to the ruler.
'server.grpc-max-send-msg-size-bytes': $._config.ruler_remote_evaluation_max_query_response_size_bytes,
},
Expand Down

0 comments on commit b87c3e2

Please sign in to comment.