Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update istio.md #9874

Closed
wants to merge 1 commit into from
Closed

Conversation

decisivedevops
Copy link

typo correction.

mod -> pod

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

typo correction.

mod -> pod
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 6, 2023
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM, thanks for catching this!

@JStickler
Copy link
Contributor

@decisivedevops I can merge this once you sign the CLA.

@JStickler
Copy link
Contributor

@decisivedevops Please sign the Contributor License Agreement (CLA) and resolve conflicts so that this can be merged.

@decisivedevops
Copy link
Author

@decisivedevops Please sign the Contributor License Agreement (CLA) and resolve conflicts so that this can be merged.

done.

@JStickler
Copy link
Contributor

@decisivedevops Thank you for signing the CLA, but the conflict still needs to be resolved.

@JStickler JStickler mentioned this pull request Dec 11, 2023
@JStickler
Copy link
Contributor

Closing as stale.

@JStickler JStickler closed this Dec 11, 2023
chaudum pushed a commit that referenced this pull request Dec 12, 2023
**What this PR does / why we need it**:

Fixes small typo from #9874, which has merge conflicts.
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
**What this PR does / why we need it**:

Fixes small typo from grafana#9874, which has merge conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants