Update recommended schema version in config reference #9182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
kavirajk
reviewed
May 1, 2023
| @@ -3649,7 +3649,7 @@ The `period_config` block configures what index schemas should be used for from | |||
| # If omitted, defaults to the same value as store. | |||
| [object_store: <string> | default = ""] | |||
|
|
|||
| # The schema version to use, current recommended schema is v11. | |||
| # The schema version to use, current recommended schema is v12. | |||
There was a problem hiding this comment.
@adeverteuil this should go into index.template file in the same directory. We generate _index.md from that template.
There was a problem hiding this comment.
Hi @kavirajk , I'm not sure what to do. All I see in index.template is a template variable like this:
### Supported contents and default values of `loki.yaml`
{{ .ConfigFile }}
I suppose I need to edit the content of .ConfigFile, but I don't know where to do that. I'm not familiar with the Loki code base, and I am guessing that this change needs to be done in a comment near the definition of this config parameter in the Loki code. Can a Loki developer please make this change where appropriate?
|
Closing as already fixed by another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.