Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger deploy CI step only on push to main or tag of new release #8991

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Apr 3, 2023

What this PR does / why we need it:

Right now, backporting to a kXXX branch causes a trigger of the deploy pipeline, which overrides already deployed newer releases.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

Right now, backporting to a kXXX branch causes a trigger of the
`deploy` pipeline, which overrides already deployed newer releases.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/dont-autodeploy-k-branch-push branch from ad82d26 to 77e64d6 Compare April 3, 2023 10:58
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Apr 3, 2023
@chaudum chaudum marked this pull request as ready for review April 3, 2023 11:05
@chaudum chaudum requested a review from a team as a code owner April 3, 2023 11:05
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

Copy link
Contributor

@vlad-diachenko vlad-diachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaudum chaudum merged commit 35c79e4 into main Apr 4, 2023
@chaudum chaudum deleted the chaudum/dont-autodeploy-k-branch-push branch April 4, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants