Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtail: Fix examples how to build it #8898

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

darxriggs
Copy link
Contributor

The build flags have to be provided before the package paths.

Otherwise the build command fails with this error:

malformed import path "--tags=promtail_journal_enabled": leading dash

See go help build:

usage: go build [-o output] [build flags] [packages]

The build flags have to be provided before the package paths.

Otherwise the `build` command fails with this error:
> malformed import path "--tags=promtail_journal_enabled": leading dash

See `go help build`:
> usage: go build [-o output] [build flags] [packages]
@darxriggs darxriggs requested review from JStickler and a team as code owners March 25, 2023 11:07
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 25, 2023
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @darxriggs

@dannykopping dannykopping merged commit 4c4c7e3 into grafana:main Mar 27, 2023
@darxriggs darxriggs deleted the fix-promtail-build-examples branch March 27, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants