Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #8783

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix typo #8783

merged 1 commit into from
Mar 13, 2023

Conversation

powerpaul17
Copy link
Contributor

@powerpaul17 powerpaul17 commented Mar 13, 2023 •
edited
Loading

What this PR does / why we need it:

Fixes a typo

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@powerpaul17 powerpaul17 requested review from JStickler and a team as code owners March 13, 2023 10:45
@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 13, 2023
DylanGuedes
DylanGuedes approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Btw, could you look in which PR the geoip was introduced? In case it was introduced before 2.7 I think it would be cool to have a changelog entry. Otherwise this looks perfect.

@powerpaul17
Copy link
Contributor Author

Hi, I think the geoip stage is not included in 2.7 but will be in the next version. This was the corresponding PR: #3493

I just thought I better fix this before it gets overlooked and causes problems later on.. 😉

@DylanGuedes
Copy link
Contributor

Hi, I think the geoip stage is not included in 2.7 but will be in the next version. This was the corresponding PR: #3493

I just thought I better fix this before it gets overlooked and causes problems later on.. wink

Nice! So yeah, no reason to add a changelog entry.

@DylanGuedes DylanGuedes merged commit 540380f into grafana:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanGuedes DylanGuedes DylanGuedes approved these changes

@JStickler JStickler Awaiting requested review from JStickler

Assignees
No one assigned
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@powerpaul17 @CLAassistant @DylanGuedes