operator: Add alertingrule tenant id label for all rules #8748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-GV
reviewed
Mar 9, 2023
operator/bundle/openshift/manifests/loki-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
operator/bundle/openshift/manifests/loki-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
operator/bundle/openshift/manifests/loki-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
xperimental
reviewed
Mar 10, 2023
periklis
force-pushed
the
alerts-tenant-label
branch
from
1483748 to
3a603c0
Compare
periklis
changed the title
periklis
force-pushed
the
alerts-tenant-label
branch
from
3a603c0 to
c17bcee
Compare
periklis
force-pushed
the
alerts-tenant-label
branch
from
3cb005f to
d9263a5
Compare
xperimental
reviewed
Mar 15, 2023
| rule.Labels = map[string]string{} | ||
| } | ||
|
|
||
| rule.Labels[tenantLabel] = a.Spec.TenantID |
There was a problem hiding this comment.
Sorry, I thought I had posted this comment last week already, but apparently I never clicked "publish" ...
It looks like we need to do a DeepCopy somewhere, because we are modifying the Groups (dirtying the lister cache). These are all pointer-types, so not only the one in alertingRuleSpec is modified but also the original in AlertingRule.
There was a problem hiding this comment.
Yeah you posted this on slack, I started working it out and stashed it. It got forgotten :(
xperimental
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The following PR adds a AlertingRule defaulting webhook is to populate the tenant ID to all rules to enable managing Alertmanager notifications per tenant.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md