Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart: fix role/PSP mapping #8656

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

hervenicol
Copy link
Contributor

What this PR does / why we need it:

Fixes role/PSP and role/SCC mapping in Helm chart.

Which issue(s) this PR fixes:
Fixes #8652

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@hervenicol hervenicol requested a review from a team as a code owner February 28, 2023 18:15
@hervenicol hervenicol force-pushed the helm-fix-psp branch 2 times, most recently from 75190b8 to ed9b4ca Compare March 2, 2023 07:06
@hervenicol
Copy link
Contributor Author

hervenicol commented Mar 2, 2023

Re-based to latest main branch (helm-loki-4.8.0).

@hervenicol
Copy link
Contributor Author

rebased to latest main branch.

@hervenicol
Copy link
Contributor Author

CI failing because of flakiness as far as I can tell 😢

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long to get a review, thanks for the fix!

@hervenicol
Copy link
Contributor Author

Thanks! Rebased to latest main so it could be merged.

@trevorwhitney trevorwhitney merged commit 9688f83 into grafana:main Mar 16, 2023
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
**What this PR does / why we need it**:

Fixes role/PSP and role/SCC mapping in Helm chart.

**Which issue(s) this PR fixes**:
Fixes grafana#8652

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [x] `CHANGELOG.md` updated
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`

Co-authored-by: Herve Nicol <12008875+hervenicol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm: wrong role config, breaking podsecuritypolicy
2 participants