Change GeneratorURL to use configurable Grafana explore URL #8500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
reviewed
Feb 13, 2023
dannykopping
approved these changes
Apr 20, 2023
github-actions
bot
added
the
type/docs
dannykopping
changed the title
pkg/ruler/base/ruler_test.go
Outdated
| @@ -1665,7 +1667,7 @@ func TestSendAlerts(t *testing.T) { | |||
| Annotations: []labels.Label{{Name: "a2", Value: "v2"}}, | |||
| StartsAt: time.Unix(2, 0), | |||
| EndsAt: time.Unix(3, 0), | |||
| GeneratorURL: "http://localhost:9090/graph?g0.expr=up&g0.tab=1", | |||
| GeneratorURL: fmt.Sprintf("http://localhost:9090/explore?left={\"queries\":[%s]}", escapedExpression), | |||
There was a problem hiding this comment.
Tiny nit: it's mildly confusing here to keep using :9090 since that's the Prometheus port
added 2 commits
April 20, 2023 15:01
|
@dannykopping I would like to rebase if you don't mind. |
There should never really be a reason to rebase (i.e. rewrite history) since we squash-merge. |
Good point! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the
GeneratorURLassociated with alerts generated by Loki. The newGeneratorURLuses a Grafana URL path.Which issue(s) this PR fixes:
Fixes #6743
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md