Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Fix read-only /tmp in single-binary mode #7695

Merged
merged 1 commit into from
Nov 22, 2022
Merged

[helm] Fix read-only /tmp in single-binary mode #7695

merged 1 commit into from
Nov 22, 2022

Conversation

MiggL
Copy link
Contributor

@MiggL MiggL commented Nov 15, 2022

What this PR does / why we need it:
When running in single-binary mode, these warnings may appear:
level=warn ts=2022-11-15T08:01:39.777179378Z caller=marker.go:214 msg="failed to process marks" path=/var/loki/compactor/retention/markers/1668476560013344947 err="open /tmp/marker-view-912253853: read-only file system"

This was previously fixed in the old chart: grafana/helm-charts#967

Which issue(s) this PR fixes:
Fixes grafana/helm-charts#609, again.

Checklist

  • Reviewed the CONTRIBUTING.md guide

@MiggL MiggL requested a review from a team as a code owner November 15, 2022 08:44
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2022

CLA assistant check
All committers have signed the CLA.

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@stefanandres
Copy link

Yes, please merge this. This breaks all retentions for existing installations that upgraded. I had to add the workaround like 10months ago back to our installations:

  # https://github.com/grafana/loki/pull/7695
  extraVolumeMounts:
    - name: tmp
      mountPath: /tmp
  extraVolumes:
    - name: tmp
      emptyDir: {}

production/helm/loki/Chart.yaml Outdated Show resolved Hide resolved
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

-           ingester	-0.1%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@jeschkies jeschkies merged commit a8c71d2 into grafana:main Nov 22, 2022
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
**What this PR does / why we need it**:
When running in single-binary mode, these warnings may appear:
`level=warn ts=2022-11-15T08:01:39.777179378Z caller=marker.go:214
msg="failed to process marks"
path=/var/loki/compactor/retention/markers/1668476560013344947 err="open
/tmp/marker-view-912253853: read-only file system"`

This was previously fixed in the old chart: grafana/helm-charts#967

**Which issue(s) this PR fixes**:
Fixes grafana/helm-charts#609, again.

**Checklist**
- [x] Reviewed the `CONTRIBUTING.md` guide
Tazmaniac added a commit to Tazmaniac/loki that referenced this pull request Feb 9, 2023
Similar to grafana#7695 but for the backend template.
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
**What this PR does / why we need it**:
When running in single-binary mode, these warnings may appear:
`level=warn ts=2022-11-15T08:01:39.777179378Z caller=marker.go:214
msg="failed to process marks"
path=/var/loki/compactor/retention/markers/1668476560013344947 err="open
/tmp/marker-view-912253853: read-only file system"`

This was previously fixed in the old chart: grafana/helm-charts#967

**Which issue(s) this PR fixes**:
Fixes grafana/helm-charts#609, again.

**Checklist**
- [x] Reviewed the `CONTRIBUTING.md` guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[loki] /tmp read-only file system
5 participants