Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated chart version to 3.3.2 to release merged changes #7618

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

vlad-diachenko
Copy link
Contributor

@vlad-diachenko vlad-diachenko commented Nov 7, 2022

changes for 3.3.2 were merged today but the chart was not released because chart version was not bumped and docs were not re-generated
fixes: #7266

@vlad-diachenko vlad-diachenko requested a review from a team as a code owner November 7, 2022 15:07
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

1 similar comment
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vlad-diachenko vlad-diachenko merged commit 15817eb into main Nov 7, 2022
@vlad-diachenko vlad-diachenko deleted the helm-fix-1 branch November 7, 2022 16:00
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
changes for 3.3.2 were merged today but the chart was not released
because chart version was not bumped and docs were not re-generated
fixes: grafana#7266
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
changes for 3.3.2 were merged today but the chart was not released
because chart version was not bumped and docs were not re-generated
fixes: grafana#7266
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
changes for 3.3.2 were merged today but the chart was not released
because chart version was not bumped and docs were not re-generated
fixes: grafana#7266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants