-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Helm] Create metricsInstance only if available #7535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Helm] Create metricsInstance only if available #7535
Conversation
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
425b90e
to
f76ee4e
Compare
@trevorwhitney updated. |
./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, looks good, thanks!
**What this PR does / why we need it**: If you're using prometheus operator and not Grafana Agent a metricsInstance shouldn't be auto-created. **Which issue(s) this PR fixes**: grafana#7529
**What this PR does / why we need it**: If you're using prometheus operator and not Grafana Agent a metricsInstance shouldn't be auto-created. **Which issue(s) this PR fixes**: grafana#7529
What this PR does / why we need it:
If you're using prometheus operator and not Grafana Agent a metricsInstance shouldn't be auto-created.
Which issue(s) this PR fixes:
#7529
Special notes for your reviewer:
I would also propose moving the definition at the same level with serviceMonitor and adding .enabled i.e.:
This of course would be a breaking change.
L.E. Just noticed this other PR: #7525
Checklist
CONTRIBUTING.md
guideCHANGELOG.md
updateddocs/sources/upgrading/_index.md