-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Backport dskit, memberlist version updates to k105 to support memberlist cluster labels and verification; re-vendor #6658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ist cluster labels and verification; re-vendor Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
…label_verification configs Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
- distributor -0.3%
+ querier 0%
+ querier/queryrange 0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0.6% |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6658-to-release-2.6.x origin/release-2.6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x d5cc77445842fc7fb83b6e6814a09eac6821a333
# Push it to GitHub
git push --set-upstream origin backport-6658-to-release-2.6.x
git switch main
# Remove the local backport branch
git branch -D backport-6658-to-release-2.6.x Then, create a pull request where the |
…ist cluster labels and verification; re-vendor (#6658) * Backport dskit, memberlist version updates to k105 to support memberlist cluster labels and verification; re-vendor Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Quick ingester client fix using new weaveworks/middleware package Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Update memberlist.libsonnet to include new cluster_label and cluster_label_verification configs Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Lint jsonnet Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
…o support memberlist cluster labels and verification; re-vendor (#6693) * Backport dskit, memberlist version updates to k105 to support memberlist cluster labels and verification; re-vendor (#6658) * Backport dskit, memberlist version updates to k105 to support memberlist cluster labels and verification; re-vendor Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Quick ingester client fix using new weaveworks/middleware package Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Update memberlist.libsonnet to include new cluster_label and cluster_label_verification configs Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Lint jsonnet Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * manually resolved go.mod conflict * removed redundant mixin changes Co-authored-by: JordanRushing <rushing.jordan@gmail.com>
Signed-off-by: JordanRushing rushing.jordan@gmail.com
What this PR does / why we need it:
This PR backports dependency version bumps for memberlist and dskit that are currently in
main
.re:
grafana/dskit
andweaveworks/common
#6643Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Checklist
CHANGELOG.md
.docs/sources/upgrading/_index.md