Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent-bit: clarify docs, use 1.9.9 #6464

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

Dentrax
Copy link
Contributor

@Dentrax Dentrax commented Jun 22, 2022

Signed-off-by: Furkan furkan.turkal@trendyol.com

What this PR does / why we need it:

  • Pins digests for security enhancements
  • Pass -ldflags using --build-args
  • Use fluent-bit image 1.9.9
  • Use golang image 1.19.2
  • Clarify fluent-bit readme

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@Dentrax Dentrax requested a review from a team as a code owner June 22, 2022 18:54
@CLAassistant
Copy link

CLAassistant commented Jun 22, 2022

CLA assistant check
All committers have signed the CLA.

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@stale
Copy link

stale bot commented Aug 13, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Aug 13, 2022
Signed-off-by: Furkan <furkan.turkal@trendyol.com>
@Dentrax Dentrax changed the title fluent-bit: clarify docs, use 1.9.5 fluent-bit: clarify docs, use 1.9.9 Oct 12, 2022
@Dentrax
Copy link
Contributor Author

Dentrax commented Oct 12, 2022

rebased. bump to 1.9.9

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small nit

clients/cmd/fluent-bit/README.md Outdated Show resolved Hide resolved
@stale stale bot removed stale A stale issue or PR that will automatically be closed. labels Nov 7, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

1 similar comment
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
- querier/queryrange	-0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@MichelHollands MichelHollands merged commit 28d6a97 into grafana:main Nov 8, 2022
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
**What this PR does / why we need it**:

* Pins digests for security enhancements
* Pass `-ldflags` using `--build-args`
* Use fluent-bit image `1.9.9`
* Use golang image `1.19.2`
* Clarify fluent-bit readme

Signed-off-by: Furkan <furkan.turkal@trendyol.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
**What this PR does / why we need it**:

* Pins digests for security enhancements
* Pass `-ldflags` using `--build-args`
* Use fluent-bit image `1.9.9`
* Use golang image `1.19.2`
* Clarify fluent-bit readme

Signed-off-by: Furkan <furkan.turkal@trendyol.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
chaudum pushed a commit that referenced this pull request Jan 25, 2023
**What this PR does / why we need it**:

* Pins digests for security enhancements
* Pass `-ldflags` using `--build-args`
* Use fluent-bit image `1.9.9`
* Use golang image `1.19.2`
* Clarify fluent-bit readme

Signed-off-by: Furkan <furkan.turkal@trendyol.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants