Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #6413 and #6377 to k102 #6422

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Conversation

JordanRushing
Copy link
Contributor

@JordanRushing JordanRushing commented Jun 17, 2022

What this PR does / why we need it:
This PR backports aa31b46 and 666bac2 to k102.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@JordanRushing JordanRushing added the dependencies Pull requests that update a dependency file label Jun 17, 2022
@JordanRushing JordanRushing requested a review from a team as a code owner June 17, 2022 16:08
@JordanRushing JordanRushing self-assigned this Jun 17, 2022
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0.4%
+        distributor	0%
-            querier	-0.3%
- querier/queryrange	-0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0.2%
-               loki	-1.2%

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0.5%
+        distributor	0%
-            querier	-0.3%
- querier/queryrange	-0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0.2%
-               loki	-1.2%

* Revert "Loki Prometheus mixin: templatize cluster label (grafana#6353)"

This reverts commit 459036f.

* Replace `loki-mixin` dependency to working commit.

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
(cherry picked from commit 666bac2)
@JordanRushing JordanRushing changed the title Backport #6413 to k102 Backport #6413 and #6377 to k102 Jun 17, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0.4%
-        distributor	-0.3%
-            querier	-0.3%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0.2%
-               loki	-1.2%

@JordanRushing JordanRushing merged commit 372961d into grafana:k102 Jun 17, 2022
@vlad-diachenko vlad-diachenko added the backport release-2.6.x Tag a PR with this label to create a PR which cherry pics it into the release-2.6.x branch label Jun 24, 2022
grafanabot pushed a commit that referenced this pull request Jun 24, 2022
* Backport memberlist dependency version pin to k102

Signed-off-by: JordanRushing <rushing.jordan@gmail.com>

* Revert "Loki Prometheus mixin: templatize cluster label" (#6377)

* Revert "Loki Prometheus mixin: templatize cluster label (#6353)"

This reverts commit 459036f.

* Replace `loki-mixin` dependency to working commit.

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
(cherry picked from commit 666bac2)

Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
(cherry picked from commit 372961d)
vlad-diachenko pushed a commit that referenced this pull request Jun 24, 2022
* Backport memberlist dependency version pin to k102

Signed-off-by: JordanRushing <rushing.jordan@gmail.com>

* Revert "Loki Prometheus mixin: templatize cluster label" (#6377)

* Revert "Loki Prometheus mixin: templatize cluster label (#6353)"

This reverts commit 459036f.

* Replace `loki-mixin` dependency to working commit.

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
(cherry picked from commit 666bac2)

Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
(cherry picked from commit 372961d)

Co-authored-by: JordanRushing <rushing.jordan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.6.x Tag a PR with this label to create a PR which cherry pics it into the release-2.6.x branch dependencies Pull requests that update a dependency file size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants