Don't interrupt the query path if deletes aren't available #6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
MasslessParticle
requested review from
MichelHollands,
simonswine and
sandeepsukhani
kavirajk
approved these changes
Jun 13, 2022
| @@ -177,7 +177,7 @@ func (q *SingleTenantQuerier) SelectSamples(ctx context.Context, params logql.Se | |||
|
|
|||
| params.SampleQueryRequest.Deletes, err = q.deletesForUser(ctx, params.Start, params.End) | |||
| if err != nil { | |||
| return nil, err | |||
| level.Error(spanlogger.FromContext(ctx)).Log("msg", "failed loading deletes for user", "err", err) | |||
There was a problem hiding this comment.
nit: since you saying for user, nice to include tenat-id as well in the error log?
There was a problem hiding this comment.
I think that should be covered by the spanlogger: https://github.com/grafana/dskit/blob/ebb5c6de233d26951aef41eada3cab3295ecb368/spanlogger/spanlogger.go#L99-L111
chaudum
approved these changes
Jun 13, 2022
owen-d
approved these changes
Jun 13, 2022
grafanabot
pushed a commit
that referenced
this pull request
Jun 13, 2022
(cherry picked from commit efda5b2)
MasslessParticle
added a commit
that referenced
this pull request
Jun 16, 2022
grafanabot
pushed a commit
that referenced
this pull request
Jun 23, 2022
(cherry picked from commit efda5b2)
MichelHollands
pushed a commit
that referenced
this pull request
Jun 23, 2022
grafanabot
added a commit
that referenced
this pull request
Jun 24, 2022
vlad-diachenko
pushed a commit
that referenced
this pull request
Jun 24, 2022
This was referenced Jun 28, 2022
chaudum
added a commit
that referenced
this pull request
Jun 30, 2022
To avoid showing deleted data, the querier originally failed when deletes were unavailable. If the compactor becomes unavailable this can cause Loki to stop responding to queries altogether. This PR changes the querier to log an error but continue servicing the request when it fails to get deletes. Extends PR #6368 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
4 tasks
MasslessParticle
pushed a commit
that referenced
this pull request
Jun 30, 2022
To avoid showing deleted data, the querier originally failed when deletes were unavailable. If the compactor becomes unavailable this can cause Loki to stop responding to queries altogether. This PR changes the querier to log an error but continue servicing the request when it fails to get deletes. Extends PR #6368 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
grafanabot
pushed a commit
that referenced
this pull request
Jun 30, 2022
To avoid showing deleted data, the querier originally failed when deletes were unavailable. If the compactor becomes unavailable this can cause Loki to stop responding to queries altogether. This PR changes the querier to log an error but continue servicing the request when it fails to get deletes. Extends PR #6368 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit a1745c7)
chaudum
added a commit
that referenced
this pull request
Jun 30, 2022
To avoid showing deleted data, the querier originally failed when deletes were unavailable. If the compactor becomes unavailable this can cause Loki to stop responding to queries altogether. This PR changes the querier to log an error but continue servicing the request when it fails to get deletes. Extends PR #6368 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit a1745c7)
grafanabot
pushed a commit
that referenced
this pull request
Jul 14, 2022
To avoid showing deleted data, the querier originally failed when deletes were unavailable. If the compactor becomes unavailable this can cause Loki to stop responding to queries altogether. This PR changes the querier to log an error but continue servicing the request when it fails to get deletes. Extends PR #6368 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit a1745c7)
MasslessParticle
pushed a commit
that referenced
this pull request
Jul 14, 2022
… (#6683) To avoid showing deleted data, the querier originally failed when deletes were unavailable. If the compactor becomes unavailable this can cause Loki to stop responding to queries altogether. This PR changes the querier to log an error but continue servicing the request when it fails to get deletes. Extends PR #6368 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit a1745c7) Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid showing deleted data, the querier originally failed when deletes were unavailable. If the compactor becomes unavailable this can cause loki to stop responding to queries altogether. This PR changes the querier to log an error but continue servicing the request when it fails to get deletes.
It also adds metrics to the
delete_requests_clientso we can alert when there is a chronic failure to get delete requests.