Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not initialize tsdb index store when using index gateway client for queries #6305

Merged

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
When Loki is configured to run the index gateway client for doing tsdb queries, we also initialize tsdb index store instance just to satisfy the IndexStore interface here, which is just a fallback for keeping index gateway client and store backwards compatible.
This causes us to un-necessarily run an instance of indexshipper which would try to sync the files locally if query readiness is configured.

This PR changes the code to make the fallbackStore for NewIndexGatewayClientStore optional and keep it nil when initializing it for tsdb index store.

@sandeepsukhani sandeepsukhani requested a review from a team as a code owner June 3, 2022 11:52
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the build passes (bit of linting/etc) LGTM

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
-            storage	-0.5%
+           chunkenc	0%
+              logql	0%
-               loki	-0.1%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants