Import memberlist.libsonnet in loki.libsonnet. #6294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
dannykopping
approved these changes
Jun 2, 2022
owen-d
pushed a commit
that referenced
this pull request
Jun 2, 2022
* Memberlist related jsonnet (#6253) * Add memberlist.libsonnet and modify loki services so we can set the port when using memberlist for the ring. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Missed the + for the ruler ring config here. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Fix linting. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Import memberlist.libsonnet in loki.libsonnet. (#6294) Signed-off-by: Callum Styan <callumstyan@gmail.com>
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required so that the memberlist jsonnet code can be used easily. Missed it in my previous PR that added the
memberlist.libonnsetfile.Signed-off-by: Callum Styan callumstyan@gmail.com