doc(storage-example-configs): AWS single store configs #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our example configs are bit misleading here. Particularly AWS deployment. https://grafana.com/docs/loki/latest/storage/#examples As a new user, I come here and all I can conclude is, we cannot use s3 as a single store under AWS deployment. Doc seems to recommend AWS deployment always needs S3 + DynamoDB. (in fact it was real confusion for new user from the community) https://grafana.slack.com/archives/CEPJRLQNL/p1652867888720979 Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
- distributor -0.3%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
sandeepsukhani
requested changes
May 19, 2022
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0.3%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
kavirajk
added
the
backport release-2.5.x
grafanabot
pushed a commit
that referenced
this pull request
May 20, 2022
* doc(storage-example-configs): AWS single store configs Our example configs are bit misleading here. Particularly AWS deployment. https://grafana.com/docs/loki/latest/storage/#examples As a new user, I come here and all I can conclude is, we cannot use s3 as a single store under AWS deployment. Doc seems to recommend AWS deployment always needs S3 + DynamoDB. (in fact it was real confusion for new user from the community) https://grafana.slack.com/archives/CEPJRLQNL/p1652867888720979 Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * Update schema_config.configs.store Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> (cherry picked from commit a58dc3f)
kavirajk
added a commit
that referenced
this pull request
May 20, 2022
* doc(storage-example-configs): AWS single store configs Our example configs are bit misleading here. Particularly AWS deployment. https://grafana.com/docs/loki/latest/storage/#examples As a new user, I come here and all I can conclude is, we cannot use s3 as a single store under AWS deployment. Doc seems to recommend AWS deployment always needs S3 + DynamoDB. (in fact it was real confusion for new user from the community) https://grafana.slack.com/archives/CEPJRLQNL/p1652867888720979 Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * Update schema_config.configs.store Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> (cherry picked from commit a58dc3f) Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
This was referenced Jun 28, 2022
osg-grafana
added
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our example configs are bit misleading here. Particularly AWS deployment.
https://grafana.com/docs/loki/latest/storage/#examples
As a new user, I come here and all I can conclude is, we cannot use s3 as a single store under AWS deployment. Doc seems to recommend AWS deployment always needs S3 + DynamoDB.
(in fact it was real confusion for new user from the community)
https://grafana.slack.com/archives/CEPJRLQNL/p1652867888720979
Signed-off-by: Kaviraj kavirajkanagaraj@gmail.com
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist