Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fake credentials in storage/chunk/storage tests #6187

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Use fake credentials in storage/chunk/storage tests #6187

merged 1 commit into from
Jun 6, 2022

Conversation

foutrelis
Copy link
Contributor

What this PR does / why we need it:
Allows the storage tests to pass when building loki 2.5.0 for Arch Linux.

Which issue(s) this PR fixes:
Fixes #6185

Special notes for your reviewer:
Please double check that this only affects tests and doesn't have any unintentional side effects.

Checklist

  • [N/A] Documentation added
  • [N/A] Tests updated
  • [N/A] Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • [N/A] Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@foutrelis
Use fake credentials in storage/chunk/storage tests
f1eb7a8 
Enable insecure mode for the GCS client so fake credentials are used
when running the storage tests (see commit c0cc004 ("gcs client:
use fake credentials in unit test").

Fixes: #6185
@foutrelis foutrelis requested a review from a team as a code owner May 18, 2022 08:54
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@foutrelis
Copy link
Contributor Author

I also reproduced the issue and verified the fix on main. 🐭️

@owen-d as the reviewer of #5834, what do you think about this one?

chaudum
chaudum approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

trevorwhitney
trevorwhitney approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

DylanGuedes
DylanGuedes approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@slim-bean slim-bean merged commit a877feb into grafana:main Jun 6, 2022
@foutrelis foutrelis deleted the use-fake-gcs-credentials-in-storage-tests branch June 6, 2022 15:42
This was referenced Jun 28, 2022
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

@trevorwhitney trevorwhitney trevorwhitney approved these changes

@DylanGuedes DylanGuedes DylanGuedes approved these changes

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures in pkg/storage/chunk/storage due to missing credentials
6 participants
@foutrelis @grafanabot @chaudum @trevorwhitney @DylanGuedes @slim-bean