Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: Redact credentials when marshalled to YAML #6186

Merged
merged 6 commits into from
May 19, 2022
Merged

security: Redact credentials when marshalled to YAML #6186

merged 6 commits into from
May 19, 2022

Commits on May 18, 2022

  1. security: Redact BOS credentials when marshalled to YAML 

    Change the type of the credentials flags for the BOS client
configuration from string to flagext.Secret, which
automatically redacts to `********` when marshalled to YAML.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed May 18, 2022
    Configuration menu
    Copy the full SHA
    2cef06c View commit details
    Browse the repository at this point in the history

  2. fixup! security: Redact BOS credentials when marshalled to YAML 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed May 18, 2022
    Configuration menu
    Copy the full SHA
    84893f9 View commit details
    Browse the repository at this point in the history

  3. Use flagext.Secret for S3 object client credentials 

    instead of a package private, similar implementation of a secret type flag

The redacted output of the value changes from `redacted` to `********`.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed May 18, 2022
    Configuration menu
    Copy the full SHA
    f2d5c73 View commit details
    Browse the repository at this point in the history

  4. Only redact secret_access_key and leave access_key_id plain string flag 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed May 18, 2022
    Configuration menu
    Copy the full SHA
    c740e3b View commit details
    Browse the repository at this point in the history

  5. fixup! Only redact secret_access_key and leave access_key_id plain st… 

    …ring flag

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed May 18, 2022
    Configuration menu
    Copy the full SHA
    9640edd View commit details
    Browse the repository at this point in the history

  6. Add credential redaction test 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed May 18, 2022
    Configuration menu
    Copy the full SHA
    eb95c23 View commit details
    Browse the repository at this point in the history