tsdb query fixes #6142
Merged
tsdb query fixes #6142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
- logql -0.5%
+ loki 0% |
owen-d
approved these changes
May 12, 2022
| @@ -139,11 +139,15 @@ func (s *indexShipper) AddIndex(tableName, userID string, index index.Index) err | |||
|
|
|||
| func (s *indexShipper) ForEach(ctx context.Context, tableName, userID string, callback func(index index.Index) error) error { | |||
| if s.downloadsManager != nil { | |||
| return s.downloadsManager.ForEach(ctx, tableName, userID, callback) | |||
| if err := s.downloadsManager.ForEach(ctx, tableName, userID, callback); err != nil { | |||
There was a problem hiding this comment.
I thought this was by design: only using either the downloads mgr or the uploads mgr so we didn't query the same indices in R/W mode for the shipper.
| @@ -186,7 +186,7 @@ func parseMultitenantTSDBNameFromBase(name string) (res MultitenantTSDBIdentifie | |||
| } | |||
|
|
|||
| xs := strings.Split(trimmed, "-") | |||
| if len(xs) != 2 { | |||
| if len(xs) < 2 { | |||
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Doing some minor fixes for the issues that I found on my local setup:
-in their names were failing to be opened.__name__matcher was not removed from queries passed to tsdb head.