Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document /services API endpoint #6111

Merged

Conversation

dannykopping
Copy link
Contributor

Signed-off-by: Danny Kopping danny.kopping@grafana.com

What this PR does / why we need it:
This PR documents the /services endpoint, which can be used to determine which services are in an unexpected state.

Which issue(s) this PR fixes:
Related: #6103

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

Danny Kopping added 2 commits May 6, 2022 12:09
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping changed the title Document /services API endpoint Document /services API endpoint May 6, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0.4%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dannykopping dannykopping merged commit 8838530 into grafana:main May 6, 2022
@dannykopping dannykopping deleted the dannykopping/services-endpoint branch May 6, 2022 10:24
@dannykopping
Copy link
Contributor Author

Crap, sorry @KMiller-Grafana - I forgot to wait for you to approve.
Please let me know if there are any changes you would like made, and I'll submit a new PR

@osg-grafana osg-grafana added type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories and removed area/docs labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants