Docs: remove Cortex references #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KMiller-Grafana
commented
May 2, 2022
•
KMiller-Grafana
commented
- References to "cortextool" remain in the docs
- Remove references to cortex #6015 changed other references, but missed just one in an Azure storage msg. This PR includes that 1 code change.
trevorwhitney
approved these changes
May 2, 2022
| @@ -1802,7 +1802,7 @@ memcached_client: | |||
| [service: <string> | default = "memcached"] | |||
|
|
|||
| # (Experimental) Comma-separated addresses list in DNS Service Discovery format: | |||
| # https://cortexmetrics.io/docs/configuration/arguments/#dns-service-discovery | |||
| # https://grafana.com/docs/mimir/latest/operators-guide/configuring/about-dns-service-discovery/ | |||
There was a problem hiding this comment.
I think this is the right thing to do for now, but we should add an issue to eventually a) replace this with our own version and not link out to Mimir, or b) host this shared dskit stuff somewhere outside of mimir specific docs.
| Loki's `ruler` component is based on Cortex's `ruler`. | ||
|
|
||
| See Cortex's guide for [horizontally scaling the `ruler`](https://cortexmetrics.io/docs/guides/ruler-sharding/) using the ring. | ||
| See Mimir's guide for [configuring Grafana Mimir hash rings](https://grafana.com/docs/mimir/latest/operators-guide/configuring/configuring-hash-rings/) for scaling the ruler using a ring. |
There was a problem hiding this comment.
same comment as above re: shared dskit docs
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.