docs: describe ordering in http query results #6024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavirajk
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
LGTM 👍 thanks @gabor.
@KMiller-Grafana leave it to you for final approval
KMiller-Grafana
suggested changes
May 6, 2022
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
KMiller-Grafana
approved these changes
May 20, 2022
This was referenced Jun 28, 2022
osg-grafana
added
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull-request describes the ordering of results when using
/queryand/query_rangeHTTP endpoints.it is important to know whether one can rely on the results being ordered or not (for example, in the grafana loki datasource, if we cannot rely on the ordering of results, we have to sort the data)
NOTE: i do not know if what i described here is guaranteed or not. i made some tests, and it seems to work this way. it would be great if a Loki developer could also verify this info. (if it is not guaranteed, i can update the pull-request so that the docs will mention that the ordering is not guaranteed)
also, there was an error in the query-range-matrix-results format description, i fixed that.