Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: logerr v2 update #5987

Merged
merged 3 commits into from
Apr 26, 2022
Merged

operator: logerr v2 update #5987

merged 3 commits into from
Apr 26, 2022

Conversation

Red-GV
Copy link
Contributor

@Red-GV Red-GV commented Apr 21, 2022

What this PR does / why we need it:
This PR updates the logerr package to v2. It also changes some methods to return errors instead of taking in a logger as an argument.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@Red-GV Red-GV requested a review from a team as a code owner April 21, 2022 13:16
Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@periklis periklis merged commit bcb8009 into grafana:main Apr 26, 2022
@Red-GV Red-GV deleted the operator-logerr-v2 branch August 22, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants