Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string representation of boltdb shipper mode #5982

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Add string representation of boltdb shipper mode #5982

merged 1 commit into from
Apr 21, 2022

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 21, 2022 •
edited
Loading

Makes the log output significantly more meaningful.

Before:

level=info ts=2022-04-21T07:35:01.687187409Z caller=shipper_index_client.go:107 msg="starting boltdb shipper in 0 mode"

After:

level=info ts=2022-04-21T07:35:01.687187409Z caller=shipper_index_client.go:107 msg="starting boltdb shipper in read-write mode"

@simonswine
Add string representation of boltdb shipper mode
30e3a45 
Makes the log output significantly more meaningful.
@simonswine simonswine marked this pull request as ready for review April 21, 2022 07:36
@simonswine simonswine requested a review from a team as a code owner April 21, 2022 07:36
kavirajk
kavirajk approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat :)

@kavirajk kavirajk merged commit 3376596 into main Apr 21, 2022
@kavirajk kavirajk deleted the 20220421_mode-string-representation branch April 21, 2022 07:50
This was referenced Jun 28, 2022
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis approved these changes

@kavirajk kavirajk kavirajk approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonswine @periklis @kavirajk