Upgrade golang version to v1.17.9 correctly tag build image #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was using the makefile first. Now read the docs again: https://github.com/grafana/loki/blob/main/docs/sources/maintaining/release-loki-build-image.md
simonswine
force-pushed
the
20220413_golang-1.17.9-correctly-build-image
branch
from
d389c75 to
5bc91f6
Compare
simonswine
changed the title
sandeepsukhani
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise version of build image correctly
Was raising the makefile first in #5899 . Now read the docs again:
https://github.com/grafana/loki/blob/main/docs/sources/maintaining/release-loki-build-image.md