[promtail] Mark promtail single client config flags and config file block as deprecated #5842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecated. Signed-off-by: Callum Styan <callumstyan@gmail.com>
`clients`. Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
kavirajk
reviewed
Apr 11, 2022
| @@ -1797,7 +1797,7 @@ server: | |||
| positions: | |||
| filename: /var/log/positions.yaml # This location needs to be writeable by Promtail. | |||
|
|
|||
| client: | |||
| clients: | |||
There was a problem hiding this comment.
Q: if we are chaning client -> clients then below url should also be changed to array?
There was a problem hiding this comment.
yes, thanks for catching this
client Signed-off-by: Callum Styan <callumstyan@gmail.com>
kavirajk
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be confusing to end users to try and understand the interaction between setting
client,clients(in the config file), and cli flagsclient.*(such asclient.url) as to which has priority and what will happen if multiple are set. See this community slack thread.Here I am proposing that we mark the config file
clientblock and CLIclient.*flags as deprecated, including a warning log line when they are used, in preparation for removing them in a future release.Signed-off-by: Callum Styan callumstyan@gmail.com
Checklist
CHANGELOG.mdabout the changes.