Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for updated deletion api #5763

Merged

Conversation

MichelHollands
Copy link
Contributor

What this PR does / why we need it:

This is the updated documentation for the changes to the deletion api in PR #5481 .

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

Signed-off-by: Michel Hollands michel.hollands@grafana.com

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those changes. LGTM

docs/sources/api/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some minor nits but other than that it LGTM.

docs/sources/operations/storage/logs-deletion.md Outdated Show resolved Hide resolved
docs/sources/operations/storage/logs-deletion.md Outdated Show resolved Hide resolved
docs/sources/operations/storage/logs-deletion.md Outdated Show resolved Hide resolved
docs/sources/api/_index.md Show resolved Hide resolved
MichelHollands and others added 8 commits April 26, 2022 11:00
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
Co-authored-by: Christian Simon <simon@swine.de>
Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@MichelHollands MichelHollands force-pushed the update_docs_for_deletion_mode_cfg_variable branch from 8153361 to 0b73027 Compare April 26, 2022 10:00
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
docs/sources/api/_index.md Outdated Show resolved Hide resolved
docs/sources/configuration/_index.md Outdated Show resolved Hide resolved
docs/sources/operations/storage/logs-deletion.md Outdated Show resolved Hide resolved
docs/sources/operations/storage/logs-deletion.md Outdated Show resolved Hide resolved
docs/sources/operations/storage/logs-deletion.md Outdated Show resolved Hide resolved
docs/sources/operations/storage/logs-deletion.md Outdated Show resolved Hide resolved
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions.

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants