Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy cortex/tools/querytee package dependency into Loki #5165

Merged
merged 4 commits into from
Jan 19, 2022

Conversation

DylanGuedes
Copy link
Contributor

@DylanGuedes DylanGuedes commented Jan 17, 2022

What this PR does / why we need it:
As a part of removing Loki dependency on cortex packages, we decided to copy the tools/querytee package from cortex to Loki itself.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@DylanGuedes DylanGuedes changed the title Fork cortex querytee Copy cortex/tools/querytee package dependency into Loki Jan 17, 2022
@DylanGuedes DylanGuedes marked this pull request as ready for review January 17, 2022 19:49
@DylanGuedes DylanGuedes requested a review from a team as a code owner January 17, 2022 19:49
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DylanGuedes DylanGuedes marked this pull request as draft January 18, 2022 11:53
@DylanGuedes DylanGuedes marked this pull request as ready for review January 18, 2022 19:12
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 66bf9f6 into grafana:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants