Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock in disconnecting querier #5063

Merged
merged 5 commits into from
Jan 10, 2022
Merged

Fix deadlock in disconnecting querier #5063

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f0dc81
Fix deadlock in disconnecting querier
cyriltovena Jan 6, 2022
bad3451
lint
cyriltovena Jan 7, 2022
4cc1e9c
Update pkg/querier/worker/worker_test.go
cyriltovena Jan 10, 2022
66b8e62
Update pkg/querier/worker/worker_test.go
cyriltovena Jan 10, 2022
fbc7037
Uses in-memory GRPC server for tests
cyriltovena Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pkg/querier/worker/worker_test.go 
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
  • Loading branch information
@cyriltovena @trevorwhitney
cyriltovena and trevorwhitney authored Jan 10, 2022
commit 66b8e62bdee7e89783c48e9c2d6c068a82c42504
2 changes: 1 addition & 1 deletion pkg/querier/worker/worker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func TestResetConcurrency(t *testing.T) {
expectedConcurrency: 2,
},
{
name: "Test parallelism per target",
name: "Test concurrency equal to parallelism * target when MatchMaxConcurrency is false",
parallelism: 4,
maxConcurrent: 0,
numTargets: 2,
Expand Down