Chore: Copy cortex/util/math into Loki
#5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
cyriltovena
reviewed
Jan 5, 2022
pkg/util/math/rate.go
Outdated
| init bool | ||
| } | ||
|
|
||
| func NewEWMARate(alpha float64, interval time.Duration) *EwmaRate { |
There was a problem hiding this comment.
Is this used somewhere ? Not sure it is.
There was a problem hiding this comment.
Yea you are right. Removed it.
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
sandeepsukhani
requested changes
Jan 5, 2022
Comment on lines
33
to
36
| "github.com/grafana/loki/pkg/util/math" | ||
|
|
||
| "github.com/grafana/loki/pkg/util/spanlogger" | ||
|
|
There was a problem hiding this comment.
Can you please remove unwanted spaces here?
Same for some of the other files updated in this PR.
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
sandeepsukhani
requested changes
Jan 5, 2022
| @@ -9,7 +9,7 @@ import ( | |||
| otlog "github.com/opentracing/opentracing-go/log" | |||
| "github.com/pkg/errors" | |||
|
|
|||
| "github.com/cortexproject/cortex/pkg/util/math" | |||
| "github.com/grafana/loki/pkg/util/math" | |||
|
|
|||
There was a problem hiding this comment.
One more here. Sorry for being picky, we would miss fixing it until we start working on it again.
pkg/storage/chunk/util/util.go
Outdated
| @@ -9,7 +9,7 @@ import ( | |||
|
|
|||
| ot "github.com/opentracing/opentracing-go" | |||
|
|
|||
| "github.com/cortexproject/cortex/pkg/util/math" | |||
| "github.com/grafana/loki/pkg/util/math" | |||
|
|
|||
| @@ -7,7 +7,7 @@ import ( | |||
| "github.com/stretchr/testify/require" | |||
| "google.golang.org/grpc" | |||
|
|
|||
| util_math "github.com/cortexproject/cortex/pkg/util/math" | |||
| util_math "github.com/grafana/loki/pkg/util/math" | |||
|
|
|||
| @@ -5,7 +5,7 @@ import ( | |||
| "sync" | |||
| "unsafe" | |||
|
|
|||
| util_math "github.com/cortexproject/cortex/pkg/util/math" | |||
| util_math "github.com/grafana/loki/pkg/util/math" | |||
|
|
|||
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
|
Fixed the spacing issue @sandeepsukhani. Thanks for the catch :) (thought |
sandeepsukhani
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Copy the
cortex/util/mathdependency into Loki.Also moved some helpers from
util/math.go->util/mathpackage.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.