Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable http2 for GCS. #4942

Merged
merged 10 commits into from
Jan 3, 2022
Merged

Allow to disable http2 for GCS. #4942

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
558a925
Allow to disable http2 for GCS.
cyriltovena Dec 16, 2021
6256b14
update changelog
cyriltovena Dec 16, 2021
0b95a0e
Update pkg/storage/chunk/gcp/gcs_object_client.go
cyriltovena Dec 16, 2021
1719363
update comment
cyriltovena Dec 16, 2021
7d0744b
Update docs/sources/configuration/_index.md
cyriltovena Jan 3, 2022
7434046
Update CHANGELOG.md
cyriltovena Jan 3, 2022
d2126f7
Reduce MaxIdleConns to a more standard value.
cyriltovena Jan 3, 2022
741658b
Allow to configure max parallelism for fetching chunks
cyriltovena Jan 3, 2022
273167f
Merge remote-tracking branch 'upstream/main' into allow-disabling-http2
cyriltovena Jan 3, 2022
e099779
Fixes tests with no default config
cyriltovena Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes tests with no default config 
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
  • Loading branch information
@cyriltovena
cyriltovena committed Jan 3, 2022
commit e099779f182dff33ce31c1104601e1e92b4ccb79
6 changes: 5 additions & 1 deletion pkg/storage/chunk/objectclient/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,11 @@ func (o *Client) PutChunks(ctx context.Context, chunks []chunk.Chunk) error {

// GetChunks retrieves the specified chunks from the configured backend
func (o *Client) GetChunks(ctx context.Context, chunks []chunk.Chunk) ([]chunk.Chunk, error) {
return util.GetParallelChunks(ctx, o.getChunkMaxParallel, chunks, o.getChunk)
getChunkMaxParallel := o.getChunkMaxParallel
if getChunkMaxParallel == 0 {
getChunkMaxParallel = defaultMaxParallel
}
return util.GetParallelChunks(ctx, getChunkMaxParallel, chunks, o.getChunk)
}

func (o *Client) getChunk(ctx context.Context, decodeContext *chunk.DecodeContext, c chunk.Chunk) (chunk.Chunk, error) {
Expand Down