Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[querier] s3: add getObject retry #4453

Merged
merged 13 commits into from
Oct 25, 2021
Merged

[querier] s3: add getObject retry #4453

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eae9311
[querier] s3: add getObject retry
liguozhong Oct 11, 2021
3a649f3
[querier] s3: add getObject retry
liguozhong Oct 11, 2021
ba6b430
[querier] s3: add getObject retry #4452
liguozhong Oct 11, 2021
ece44a3
[querier] s3: add getObject retry
liguozhong Oct 11, 2021
3d997cd
[querier] s3: add getObject retry #4453
liguozhong Oct 11, 2021
0d8dc80
[querier] s3: add getObject retry
liguozhong Oct 12, 2021
64e475c
[querier] s3: add getObject retry #4453
liguozhong Oct 14, 2021
2d78414
[querier] s3: add getObject retry #4453
liguozhong Oct 14, 2021
4a7bbe6
[querier] s3: add getObject retry #4453
liguozhong Oct 14, 2021
f971432
[querier] s3: add getObject retry #4453
liguozhong Oct 14, 2021
faf6585
[querier] s3: add getObject retry
liguozhong Oct 15, 2021
fcd126d
Merge branch 'main' into s3_retry
owen-d Oct 25, 2021
b3e726b
Merge branch 'main' into s3_retry
owen-d Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[querier] s3: add getObject retry #4452
  • Loading branch information
@liguozhong
liguozhong committed Oct 11, 2021
commit ba6b430331c1b2de404796ed2ab3d0b3f544e9e1
2 changes: 1 addition & 1 deletion pkg/storage/chunk/aws/s3_storage_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ func (a *S3ObjectClient) GetObject(ctx context.Context, objectKey string) (io.Re
bucket := a.bucketFromKey(objectKey)

retries := backoff.New(ctx, a.cfg.BackoffConfig)
var err error = nil
err := ctx.Err()
DylanGuedes marked this conversation as resolved.
Show resolved Hide resolved
for retries.Ongoing() {
err = instrument.CollectedRequest(ctx, "S3.GetObject", s3RequestDuration, instrument.ErrorCode, func(ctx context.Context) error {
var err error
DylanGuedes marked this conversation as resolved.
Show resolved Hide resolved
Expand Down