Adding a configurable timeout for calls to the loki server. #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating promtail test to set sane defaults for all configurations and then override for testing. Removing .idea folder from .gitignore, we should encourage people (and myself) to use global ignore for IDE configs
tomwilkie
reviewed
Mar 5, 2019
tomwilkie
reviewed
Mar 5, 2019
tomwilkie
reviewed
Mar 5, 2019
…the cancel rather than having to call it explicitly. Removed some unnecessary struct initialization.
tomwilkie
reviewed
Mar 5, 2019
xperimental
pushed a commit
to xperimental/loki
that referenced
this pull request
Nov 18, 2024
Update from upstream repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updating promtail test to set sane defaults for all configurations and then override for testing.
Removing .idea folder from .gitignore, we should encourage people (and myself) to use global ignore for IDE configs
Fixes #264