Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger compaction prior retention. #3665

Merged
merged 9 commits into from
Apr 30, 2021
Merged

Trigger compaction prior retention. #3665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dd582e6
Trigger compaction prior retention.
cyriltovena Apr 29, 2021
6687145
Hook retention into compaction.
cyriltovena Apr 29, 2021
0d6cdcb
Remove unused flags.
cyriltovena Apr 29, 2021
cbe8aff
Better comment.
cyriltovena Apr 29, 2021
b664b90
Better cancellation.
cyriltovena Apr 29, 2021
dcf018e
Missing ctx in test.
cyriltovena Apr 29, 2021
14df469
Fixes flags that are not used.
cyriltovena Apr 29, 2021
1d31dd3
Add compactor retention tests.
cyriltovena Apr 30, 2021
3ea0c03
Review feedback.
cyriltovena Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes flags that are not used. 
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
  • Loading branch information
@cyriltovena
cyriltovena committed Apr 29, 2021
commit 14df4697e10012244b0f2d5c98c9dc3024f425cb
1 change: 0 additions & 1 deletion pkg/storage/stores/shipper/compactor/compactor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ type Config struct {
SharedStoreKeyPrefix string `yaml:"shared_store_key_prefix"`
CompactionInterval time.Duration `yaml:"compaction_interval"`
RetentionEnabled bool `yaml:"retention_enabled"`
RetentionInterval time.Duration `yaml:"retention_interval"`
RetentionDeleteDelay time.Duration `yaml:"retention_delete_delay"`
RetentionDeleteWorkCount int `yaml:"retention_delete_worker_count"`
}
Expand Down
1 change: 0 additions & 1 deletion pkg/storage/stores/shipper/compactor/compactor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ func TestIsDefaults(t *testing.T) {
{&Config{
SharedStoreKeyPrefix: "index/",
CompactionInterval: 2 * time.Hour,
RetentionInterval: 10 * time.Minute,
RetentionDeleteDelay: 2 * time.Hour,
RetentionDeleteWorkCount: 150,
}, true},
Expand Down