Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki-Canary: Backoff retries on query failures, add histograms for query performance. #2413

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Loki-Canary: Backoff retries on query failures, add histograms for query performance. #2413

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1840dc
Canary needs to wait before spot-checking entries some reasonable amo…
slim-bean Jul 23, 2020
7342192
Adding backoff to queries if they fail specifically waiting 5mins whe…
slim-bean Jul 24, 2020
b1b1a3a
fix order of parameters
slim-bean Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix order of parameters
  • Loading branch information
@slim-bean
slim-bean committed Jul 24, 2020
commit b1b1a3a070618f50bc81e13916c6f6ce7633f795
2 changes: 1 addition & 1 deletion pkg/canary/comparator/comparator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ func TestMetricTest(t *testing.T) {
mr := &mockReader{}
metricTestRange := 30 * time.Second
//We set the prune interval timer to a huge value here so that it never runs, instead we call spotCheckEntries manually below
c := NewComparator(actual, 1*time.Hour, 1*time.Hour, 50*time.Hour, 0, 0, 0, 4*time.Hour, 10*time.Minute, metricTestRange, writeInterval, 1, make(chan time.Time), make(chan time.Time), mr, false)
c := NewComparator(actual, 1*time.Hour, 1*time.Hour, 50*time.Hour, 0, 0, 4*time.Hour, 0, 10*time.Minute, metricTestRange, writeInterval, 1, make(chan time.Time), make(chan time.Time), mr, false)
// Force the start time to a known value
c.startTime = time.Unix(10, 0)

Expand Down