cmd/logcli: support load config from file #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
reviewed
Jan 17, 2019
tomwilkie
reviewed
Jan 17, 2019
tomwilkie
reviewed
Jan 17, 2019
|
Thanks for the PR @daixiang0! Looks like it need some more work, ping me when you've had a chance to address the feedback. |
daixiang0
force-pushed
the
support-config
branch
5 times, most recently
from
067cbed
to
2891e28
Compare
davkal
requested changes
Feb 15, 2019
daixiang0
force-pushed
the
support-config
branch
3 times, most recently
from
9b0723d
to
0ade7a3
Compare
@davkal All done, please review again. |
|
Isn't the error logged twice now? Also, @gouthamve is this good code organization in the |
daixiang0
force-pushed
the
support-config
branch
from
0ade7a3
to
31d65a9
Compare
Do you mean no need log in config.go? I have removed that.
This organization is what |
daixiang0
force-pushed
the
support-config
branch
from
31d65a9
to
a2616a7
Compare
davkal
reviewed
Feb 21, 2019
davkal
reviewed
Feb 21, 2019
davkal
reviewed
Feb 21, 2019
|
Thank you, we're almost there. Only the docs need cleaning up, then we can merge this. |
Done :） |
Signed-off-by: Xiang Dai <764524258@qq.com>
daixiang0
force-pushed
the
support-config
branch
from
6d12ee6
to
2392cc3
Compare
davkal
approved these changes
Feb 22, 2019
|
Thank you for your contribution @daixiang0 🎉 |
periklis
pushed a commit
to periklis/loki
that referenced
this pull request
Dec 11, 2023
Update from upstream repository incl. go1.20 compatibily patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support load config from file and move default config into here.
Signed-off-by: Xiang Dai 764524258@qq.com