fix: Standardise kafka (client|writer|tenant-tee) metric names #16882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The metric names are very inconsistent. Some of them are wrapped in
loki_distributor
andkafka
, others are not and don't have any prefix (!)loki_distributor_kafka_
prefix to metrics. These come from a lib and expect a registerer.loki_distributor_
prefix to metrics. These are our own code so we are already adding thekafka_
prefix but not the other bits.loki_distributor_
which I've wrapped in a registerer. It also containers a Producer client which inheririts the registerer and adds its ownkafka_
prefix (as before).This makes it a bit easier to search for these metrics. Previously they were hard to find, as some of them were called things like
buffered_fetch_records
which are nowloki_distributor_kafka_buffered_fetch_records
.