Skip to content

fix(operator): use description annotation for Prometheus alerts instead of message #16574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

fix(operator): use description annotation for Prometheus alerts instead of message #16574

merged 2 commits into from
Mar 25, 2025

Conversation

JoaoBraveCoding
Copy link
Collaborator

What this PR does / why we need it:

Before:

imagem

After:

imagem

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/LOG-6380

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@JoaoBraveCoding JoaoBraveCoding requested review from periklis, xperimental and a team as code owners March 5, 2025 17:58
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 7, 2025
@xperimental xperimental changed the title fix(operator): update alerts in PrometheusRule to descripton instead of message fix(operator): Use description annotation for PrometheusRules instead of message Mar 24, 2025
@xperimental xperimental changed the title fix(operator): Use description annotation for PrometheusRules instead of message fix(operator): Use description annotation for Prometheus alerts instead of message Mar 24, 2025
@xperimental xperimental changed the title fix(operator): Use description annotation for Prometheus alerts instead of message fix(operator): use description annotation for Prometheus alerts instead of message Mar 24, 2025
@JoaoBraveCoding JoaoBraveCoding merged commit 89cb731 into grafana:main Mar 25, 2025
68 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperimental xperimental xperimental approved these changes

@periklis periklis Awaiting requested review from periklis periklis is a code owner

Assignees
No one assigned
Labels
sig/operator size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoaoBraveCoding @xperimental