Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move evictOldStreams into separate method to use defer on mutex #16491

Open
wants to merge 1 commit into
base: feat/usage-tracker
Choose a base branch
from

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Feb 27, 2025

What this PR does / why we need it:

This commit splits evictOldStreams into evictOldStreams and evictOldStreamsPeriodic. This will all us to test evictOldStreams and also use defer to release the mutex.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner February 27, 2025 15:17
@grobinson-grafana grobinson-grafana force-pushed the grobinson/move-evict-old-streams-to-use-defer branch 2 times, most recently from 4486359 to 57856a4 Compare February 27, 2025 15:34
@grobinson-grafana grobinson-grafana force-pushed the grobinson/move-evict-old-streams-to-use-defer branch from 57856a4 to c0a12d5 Compare February 27, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant