chore: flush idle dataobjects after X seconds #16348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
|
💻 Deploy preview deleted. |
fcjack
changed the title
benclive
reviewed
Feb 18, 2025
benclive
approved these changes
Feb 18, 2025
| cfg.IdleFlushTimeout = 60 * 60 * time.Second // default to 1 hour | ||
| } | ||
|
|
||
| f.DurationVar(&cfg.IdleFlushTimeout, prefix+"idle-flush-timeout", cfg.IdleFlushTimeout, "The maximum amount of time to wait in seconds before flushing an object that is no longer receiving new writes") |
There was a problem hiding this comment.
You can set the default value as the 3rd argument in the flag definition, if you wish
| @@ -39,6 +39,10 @@ type partitionProcessor struct { | |||
| bucket objstore.Bucket | |||
| bufPool *sync.Pool | |||
|
|
|||
| // Idle stream handling | |||
| idleFlushTimout time.Duration | |||
| } | ||
|
|
||
| now := time.Now() | ||
| if now.Sub(p.lastFlush) < p.idleFlushTimout { |
There was a problem hiding this comment.
You could also use time.Since here: time.Since(p.lastFlush) < p.idleFlushTimeout
In practice it makes very little difference but its slightly easier to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We need an idle check for our objects to be flushed, since there are cases that objects are in memory until reach the configurable size.
If we stop receiving data the size won't increase and it is not flushed.
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/loki-private/issues/1359
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR